Indicate absence with a boolean return, instead of nil pointers

Open zenhack opened this issue 3 years ago • 3 comments

...per discussion.

Nov 28 '22 05:11 zenhack

Rebased on top of v2 and fixed some linter errors. Should be good to go now.

Nov 29 '22 23:11 zenhack

Codecov Report

:exclamation: No coverage uploaded for pull request base (v2@71dc5cc). Click here to learn what that means. The diff coverage is n/a.

@@          Coverage Diff          @@
##             v2      #25   +/-   ##
=====================================
  Coverage      ?   95.00%           
=====================================
  Files         ?        5           
  Lines         ?      240           
  Branches      ?        0           
=====================================
  Hits          ?      228           
  Misses        ?       10           
  Partials      ?        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Nov 29 '22 23:11 codecov[bot]

Sorry, I didn't mean that I want you to implement it but thanks for the code! I'll first put up an issue for this change to see to make sure that no one has any obligations.

Jan 29 '23 09:01 raviqqe