Ravindra Singh Gautam comments

Results 16 comments of


                                            Ravindra Singh Gautam

[HOLD] Refactor companystep to use Form

> @mananjadhav I have made the necessary changes > > 1. Used new PR template. > 2. Attached video for mobile safari > 3. Merged main branch and resolved conflicts...

[HOLD] Refactor companystep to use Form

> @ravindra-encoresky Did you get a chance to look at @luacmartins's comments? Will check.

[HOLD] Refactor companystep to use Form

@luacmartins I have fixed above mentioned changes. Please check

[HOLD] Refactor companystep to use Form

> @luacmartins I have fixed above mentioned changes. Please check @mananjadhav @sketchydroide

[HOLD] Refactor companystep to use Form

> Looking good. Just a few more comments: > > 1. Let's make [reimbursmeentAccountDraft](https://github.com/Expensify/App/blob/8fc517ef36058b44dadd481cb3a8d762fe08e1a9/src/pages/ReimbursementAccount/CompanyStep.js#L38) prop optional, since the user could be on the CompanyStep, login and not have any draft...

Did not find openai_api_key,

> Im running this on Windows 10 > I added the API KEY in the .env file but i keep getting this error > `ValidationError: 1 validation error for OpenAIEmbeddings...