ravendb icon indicating copy to clipboard operation
ravendb copied to clipboard
verified publisher icon ravendb

RavenDB-22331 - Cache isn't invaildated after Changes API reconnection

Open grisha-kotler opened this issue 1 year ago • 2 comments

Issue link

https://issues.hibernatingrhinos.com/issue/RavenDB-22331/Cache-isnt-invaildated-after-Changes-API-reconnection

Additional description

In the event of a disruption in the Changes API connection, it's essential to invalidate the cache. This is necessary because there could potentially be some changes during the downtime.

Type of change

  • [x] Bug fix
  • [ ] Regression bug fix
  • [ ] Optimization
  • [ ] New feature

How risky is the change?

  • [x] Low
  • [ ] Moderate
  • [ ] High
  • [ ] Not relevant

Backward compatibility

  • [x] Non breaking change
  • [ ] Ensured. Please explain how has it been implemented?
  • [ ] Breaking change
  • [ ] Not relevant

Is it platform specific issue?

  • [ ] Yes. Please list the affected platforms.
  • [x] No

Documentation update

  • [ ] This change requires a documentation update. Please mark the issue on YouTrack using Documentation Required tag.
  • [x] No documentation update is needed

Testing by Contributor

  • [x] Tests have been added that prove the fix is effective or that the feature works
  • [ ] Internal classes added to the test class (e.g. entity or index definition classes) have the lowest possible access modifier (preferable private)
  • [ ] It has been verified by manual testing

Testing by RavenDB QA team

  • [ ] This change requires a special QA testing due to possible performance or resources usage implications (CPU, memory, IO). Please mark the issue on YouTrack using QA Required tag.
  • [x] No special testing by RavenDB QA team is needed

Is there any existing behavior change of other features due to this change?

  • [ ] Yes. Please list the affected features/subsystems and provide appropriate explanation
  • [x] No

UI work

  • [ ] It requires further work in the Studio. Please mark the issue on YouTrack using Studio Required tag.
  • [x] No UI work is needed

grisha-kotler avatar May 05 '24 10:05 grisha-kotler

@grisha-kotler please check failing tests

arekpalinski avatar May 10 '24 11:05 arekpalinski

@grisha-kotler please check failing tests

I thought that https://github.com/ravendb/ravendb/pull/18417 will be merged first. Anyway, I pushed the fix.

grisha-kotler avatar May 12 '24 07:05 grisha-kotler

Can you please rebase and solve the conflict?

arekpalinski avatar May 16 '24 06:05 arekpalinski

test this please

arekpalinski avatar May 16 '24 18:05 arekpalinski