ravendb icon indicating copy to clipboard operation
ravendb copied to clipboard

RavenDB-22307 Corax enhancements

Open maciejaszyk opened this issue 1 year ago • 1 comments

Issue link

https://issues.hibernatingrhinos.com/issue/RavenDB-22307

Additional description

  • AndNot memory usage optimization and span fix (we were creating an invalid span)
  • Remove UnaryMatch
  • Fix MultiUnaryMatch
  • Pass Slices/FieldMetadata as constant reference instead of copying

Type of change

  • [x] Bug fix
  • [ ] Regression bug fix
  • [x] Optimization
  • [ ] New feature

How risky is the change?

  • [ ] Low
  • [x] Moderate
  • [ ] High
  • [ ] Not relevant

Backward compatibility

  • [x] Non breaking change
  • [ ] Ensured. Please explain how has it been implemented?
  • [ ] Breaking change
  • [ ] Not relevant

Is it platform specific issue?

  • [ ] Yes. Please list the affected platforms.
  • [x] No

Documentation update

  • [ ] This change requires a documentation update. Please mark the issue on YouTrack using Documentation Required tag.
  • [x] No documentation update is needed

Testing by Contributor

  • [x] Tests have been added that prove the fix is effective or that the feature works
  • [ ] Internal classes added to the test class (e.g. entity or index definition classes) have the lowest possible access modifier (preferable private)
  • [ ] It has been verified by manual testing

Testing by RavenDB QA team

  • [ ] This change requires a special QA testing due to possible performance or resources usage implications (CPU, memory, IO). Please mark the issue on YouTrack using QA Required tag.
  • [x] No special testing by RavenDB QA team is needed

Is there any existing behavior change of other features due to this change?

  • [ ] Yes. Please list the affected features/subsystems and provide appropriate explanation
  • [x] No

UI work

  • [ ] It requires further work in the Studio. Please mark the issue on YouTrack using Studio Required tag.
  • [x] No UI work is needed

maciejaszyk avatar Apr 26 '24 07:04 maciejaszyk

test this in debug please

arekpalinski avatar Apr 29 '24 08:04 arekpalinski

LGTM

redknightlois avatar May 06 '24 13:05 redknightlois