Update to latest 4.1 code

[kjk]

Putting this as a maybe.

I've ported against 4.0 branch. There's a fair amount of changes in 4.1 branch and it's non-linear with 4.0 branch so it's harder to figure out which Java check-ins need to be ported.

[ayende]

@ml054 Thoughts?

[ml054]

@kjk I think the best way (which I'm using for porting changes from .net to java) is to create git between v4.0 and 4.1 branches and pass it to file, like this:

git diff v4.0 v4.1 > diff.diff

Then you can apply those changes. I delete applied content from this diff file. I know this file is big (852KB), but please notice most of changes are additions. You can also start from rewriting one test and then try to make it green by copying necessary code.

Next time this diff file will be smaller and changes will be easier to apply.

If you find better way of doing this - please let me know.

[kjk]

A list of unique checkins in v4.1 vs v4.0 (generated with https://gist.github.com/kjk/d0bae39b62d805605d4bf4b8bd677172). Oldest (first to port) first:

New in v41 (57), oldest first:

• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/ba9ce1d6 syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/66148205 [travis] specify the latest server version to 4.1
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/f07a29b2 syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/fda7119d enabled Experimental features during tests
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/977fcc68 syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7 - fixed includers
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/6c6a8f7a syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7 - more counter tests
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/ee6c4183 syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7 - cleanup
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/91037660 syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7 - js indexes
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/60177fb1 syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7 - code cleanup
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/ce143e5d syncing with 4.1 version: b152c4aeac46d78a2c6f6fd5ad547440258660e7 - detect js indexes
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/68a0de4d sync with .net: 6a55dd7309d51275949ee0fbc6a7526b49367f88
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/21314c5b [maven-release-plugin] prepare release v4.1.0
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/3b9c600c [maven-release-plugin] prepare release v4.1.1
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/cea24ff2 moved internal test driver to test directory
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/fc68079f added missing java docs
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/4cab3361 [maven-release-plugin] prepare release v4.1.2
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/8ba8cc1c sync with .net: 412d9c18257789e0012b0673e50635c345c3056d
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/4615a871 sync with .net: 681901c242080f467dbe20c69037af73b22415e1
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/6ceb74e7 RDBC-243 isWhitespace() vs isBlank()
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/aa45699b RDBC-245 Port database smuggler to java
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/0a3ee9b2 sync with .net: a05c570f039989091437ba51f20cc4f2233f4d60
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/f58ca91e [maven-release-plugin] prepare release v4.1.3
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/2b6cec45 RDBC-266 In Java client, BatchOperation.java , getOrAddModifications() returns received value instead of modified
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/57ea51f6 sync with .net: 7204a4a3a5fc7ecd022f4f00fda3694fc747428f
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/1dca52d4 sync with .net: 7204a4a3a5fc7ecd022f4f00fda3694fc747428f
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/ed9caf59 feature: add buffer size to SubscriptionWorkerOptions
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/12544b10 RDBC-267 in class Raven.Client.Documents.Session.DocumentsChanges some fields are not used
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/f15bf6a4 using jetty: 9.4.11
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/fa9c5eb5 removed fiddler
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/8f56ec45 RavenDB-12921 - port to java
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/2f204a98 test for afterQueryExecuted invocation count
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/2b23e9e5 [maven-release-plugin] prepare release v4.1.4
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/87879685 [maven-release-plugin] prepare for next development iteration
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/9e705636 RDBC-283 [Java] Add missing Database Record fields
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/9c686dc1 connection strings CRUDs
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/621be2e3 run tests against 4.1 and 4.2
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/d7d65683 sync with .NET: 0edeeb7731da1ae27d863bf4a84f29471146f78d
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/8fbdb54b RDBC-277 Instances of double-checked locking in Java client - added volatile keyword
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/8dd9f874 network issues simulator
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/163385a0 check exit code
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/a6f468e4 tcp in proto
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/cda723bf RDBC-294 Add ETL Operations to the client
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/c23ae397 RDBC-295 DocumentSubscription.create() and createForRevisions() ignores query
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/1aef618b network simulator
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/e32d81c3 reject vs. drop packets
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/217d5c49 fixed client api failover
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/6b18ad54 bumped readme to 4.1.5
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/ce969396 wait between waitForDocumentToReplicate retires
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/cdecec70 [maven-release-plugin] prepare release v4.1.5
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/5f86a0a1 [maven-release-plugin] prepare for next development iteration
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/abc765de RDBC-195 [Java] Handle AuthorizationException explicitly in firstTopologyUpdate - added CRUD for certificates in client
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/d46d450f RDBC-290 fixed lazy test
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/0bebaf26 positive test for certificates
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/2631abf0 fixing X509Certificate2.Export() in Linux adds a multiple localKeyID bag attribute
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/c0ef66f1 fixing X509Certificate2.Export() in Linux adds a multiple localKeyID bag attribute
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/5666f3d6 set source version for java docs to 8
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/27aa8ff8 added an ability to configure conflict solver from client api

Maybe common checkins: 25

• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/34ec479d v40: https://github.com/ravendb/ravendb-jvm-client/commit/75031c53 [travis] fix wget URL
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/d7c0a0e8 v40: https://github.com/ravendb/ravendb-jvm-client/commit/a30e45e2 [maven-release-plugin] prepare for next development iteration
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/2811905c v40: https://github.com/ravendb/ravendb-jvm-client/commit/8f7134f3 versions updated
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/f33e13e4 v40: https://github.com/ravendb/ravendb-jvm-client/commit/6cee1361 introduced ability to configure trust store
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/94adeb32 v40: https://github.com/ravendb/ravendb-jvm-client/commit/caf6cdd7 unskip changes test - fixed database does not exist case
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/b3d6ff8c v40: https://github.com/ravendb/ravendb-jvm-client/commit/bcd1d9fb [maven-release-plugin] prepare for next development iteration
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/00152a59 v40: https://github.com/ravendb/ravendb-jvm-client/commit/0a885a48 RDBC-234 bug in java's executeAllPendingLazyOperations
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/23712340 v40: https://github.com/ravendb/ravendb-jvm-client/commit/05baa875 RDBC-234 bug in java's executeAllPendingLazyOperations - test
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/d1b746bc v40: https://github.com/ravendb/ravendb-jvm-client/commit/f3b89fc6 extracted certificate utils method + fixed issue with invalid request executor
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/c7c5f6c0 v40: https://github.com/ravendb/ravendb-jvm-client/commit/dce2c51f bump version in readme
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/30a8c070 v40: https://github.com/ravendb/ravendb-jvm-client/commit/dcca07e6 [maven-release-plugin] prepare for next development iteration
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/fb3d260c v40: https://github.com/ravendb/ravendb-jvm-client/commit/c9887696 bumped jackson version to 2.9.7
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/be3a0bce v40: https://github.com/ravendb/ravendb-jvm-client/commit/0c36149b RDBC-197 Validate arguments passed to GetDocumentsCommand
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/b50fbaa4 v40: https://github.com/ravendb/ravendb-jvm-client/commit/05061687 RDBC-246 Check 'single' method in java.
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/fbf419cc v40: https://github.com/ravendb/ravendb-jvm-client/commit/4af63ba0 RavenDB-12310 skip 'class' field in select fields
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/d83d4bb6 v40: https://github.com/ravendb/ravendb-jvm-client/commit/b0d699ca RDBC-246 Check 'single' method in java.
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/36209bba v40: https://github.com/ravendb/ravendb-jvm-client/commit/9f0cc461 sync with .net: 42b779151cb09c734cc2da967817e0bae9cb01aa
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/8a565254 v40: https://github.com/ravendb/ravendb-jvm-client/commit/a38ee715 bumped jackson version
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/0e09fb90 v40: https://github.com/ravendb/ravendb-jvm-client/commit/c4049812 bumped version in README
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/34e79a6b v40: https://github.com/ravendb/ravendb-jvm-client/commit/258ec22e [maven-release-plugin] prepare for next development iteration
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/0f1f24c7 v40: https://github.com/ravendb/ravendb-jvm-client/commit/88bf621a RDBC-268 [{"TopologyChange":true}] is poison pill for Java client
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/814dc8db v40: https://github.com/ravendb/ravendb-jvm-client/commit/33003ba4 fix: do not swallow deserialization exceptions
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/e944f956 v40: https://github.com/ravendb/ravendb-jvm-client/commit/84186d68 RDBC-273 incorrect handling of end == NULL in AbstractDocumentQuery._whereBetween
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/7204a4a3 v40: https://github.com/ravendb/ravendb-jvm-client/commit/1f610a54 sync with .NET: a21d569f3cf936e67a282535a3ce623a52227d1a
• [ ] v41: https://github.com/ravendb/ravendb-jvm-client/commit/c6b3d2bc v40: https://github.com/ravendb/ravendb-jvm-client/commit/bb8b3aa2 RDBC-276 test java client with oracle jdk 8 and 11 + openjdk8

New in v40 (12), oldest first:

• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/53b574d9 [travis] specify the latest server version to 4.0
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/972adc67 [maven-release-plugin] prepare release v4.0.3
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/7b052eb5 [maven-release-plugin] prepare release v4.0.4
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/44fd8512 matrix build against 4.0 and 4.1 servers
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/bddf7b3e conditionally disabled subscriptions tests against 4.1 server
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/f50f7908 sync with .net: 42019a096ffd0324e425f9d7f678383095145615
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/a536ef55 use latest nightly during build
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/e4802528 we can run subscriptions tests against v4.1 server
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/c3b55d94 RavenDB-12577 In class PatchOperation wrong null parameters check in the constructor
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/83110073 [maven-release-plugin] prepare release v4.0.5
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/5b2dac34 removed fiddler debug
• [ ] https://github.com/ravendb/ravendb-jvm-client/commit/574ed008 [maven-release-plugin] prepare release v4.0.6

Common checkins: 211