ORB_SLAM2 icon indicating copy to clipboard operation
ORB_SLAM2 copied to clipboard

Covisibility Graph - updating connections

Open dybas133 opened this issue 4 years ago • 2 comments

Acording to the paper (page 4 section D) the Covisibility Graph's connections are supposed to be both ways and get created if and only if there are at least 15 shared map points.

However by looking at the code at KeyFrame::UpdateConnections() I've noticed that connections from others to KeyFrame being updated are added if there are at least 15 common map points, as supposed, but KeyFrame has this mConnectedKeyFrameWeights = KFcounter at line 367, where all KeyFrames that have at least one common map point are added.

Is this intended or is it a bug?

The way it is now it is not undirected graph and does not keep those 15 and above common map points.

dybas133 avatar May 21 '20 12:05 dybas133

@dybas133 Hi, I have also noticed this "bug?". Have you get more knowledge about this?

zeal-up avatar Dec 07 '23 06:12 zeal-up

Hi @zeal-up,

Wow, that was such a long time ago. For over a year I haven't been working with orb slam anymore, but I remember fixing it by myself and it seemed to improve the algorithm's memory management. Also the resulted maps had less weird point clumps.

I don't have access to the code anymore, so I can't provide concrete result, but I'll try to bring it up, because I remember the way of thinking I had (give me a few days, I'm quite busy at the moment).

dybas133 avatar Dec 11 '23 13:12 dybas133