BetterDiscordAddons icon indicating copy to clipboard operation
BetterDiscordAddons copied to clipboard

[Bug] Fix BetterRoleColors

Open itzroger22 opened this issue 1 year ago • 11 comments

FIX BETTER ROLE COLORS PLZ 😭😭😭😭😭

itzroger22 avatar May 14 '24 07:05 itzroger22

i think the thing which causing the crashing is only typing indicator, i'm still testing if the issue occuring with dissabled the typing option, but at least, not crashing for now

BialySztorm avatar May 16 '24 19:05 BialySztorm

i think the thing which causing the crashing is only typing indicator, i'm still testing if the issue occuring with dissabled the typing option, but at least, not crashing for now

I tested you PR and it didn't seem to fix the colors for the Voice chat users. But I also hadn't had any crashes with this plugin previously either. It's simply not working anymore.

lextatic avatar May 20 '24 13:05 lextatic

i think the thing which causing the crashing is only typing indicator, i'm still testing if the issue occuring with dissabled the typing option, but at least, not crashing for now

I tested you PR and it didn't seem to fix the colors for the Voice chat users. But I also hadn't had any crashes with this plugin previously either. It's simply not working anymore.

Yeah, as I write in description I only figured out account description fix and pop ups username only, but the voice I not done yet.

BialySztorm avatar May 20 '24 17:05 BialySztorm

Guys) Check it

            patchVoiceUsers() {
                const { React } = BdApi;
                Patcher.after(VoiceUser.prototype, "renderName", (thisObject, _, returnValue) => {
                    if (!this.settings.modules.voice) return;
                    if (!returnValue || !returnValue.props) return;
                    const member = this.getMember(thisObject?.props?.user?.id);
                    if (!member || !member.colorString) return;

                    return React.createElement(
                        'div',
                        {
                            style: {
                                display: 'contents',
                                ['--channels-default']: member.colorString,
                                ...(this.settings.global.saturation ? {
                                    ["data-accessibility"]: "desaturate"
                                } : {}),

                            }
                        },
                        returnValue
                    );
                });
            }
            ```

vicimpa avatar Jul 20 '24 16:07 vicimpa

I fix it)

vicimpa avatar Jul 20 '24 16:07 vicimpa

I fix it)

You are a god! Thanks!

lextatic avatar Jul 20 '24 20:07 lextatic

Yo) I small refactor and fix color with hover and active micro BetterRoleColors.plugin.js.zip Developers, please check. I can make pull request.

vicimpa avatar Jul 21 '24 05:07 vicimpa

@vicimpa your file is working but memberlist headers are not colored.

wilecoyote avatar Aug 23 '24 10:08 wilecoyote

@vicimpaВаш файл работает, но заголовки списка участников не окрашены.

What do you mean?

vicimpa avatar Aug 26 '24 05:08 vicimpa

It should be the same color as the bot's name image because of this plugin setting image

wilecoyote avatar Aug 27 '24 04:08 wilecoyote

Yo) I small refactor and fix color with hover and active micro BetterRoleColors.plugin.js.zip Developers, please check. I can make pull request.

Thanks, that's work!

Please update https://github.com/zerebos/BetterDiscordAddons/blob/master/Plugins/BetterRoleColors/BetterRoleColors.plugin.js @zerebos

alexbofa avatar Sep 04 '24 17:09 alexbofa