meta-rauc icon indicating copy to clipboard operation
meta-rauc copied to clipboard

Published 20 hours ago • verified publisher icon rauc

Switch from "_" to ":" separator

Open tlammi opened this issue 2 years ago • 2 comments

Yocto Kirkstone switched from underscore to colon separator. Should this be done for meta-rauc also? I.e. switch from RAUC_SLOT_<slot> to RAUC_SLOT:<slot>.

tlammi avatar May 10 '22 09:05 tlammi

For RAUC_SLOT_<slot>, the slot name is not a bitbake override, so I'm skeptical if that would work. Which benefits do you see?

jluebbe avatar May 12 '22 06:05 jluebbe

I don't think it affects the behavior since if a RAUC slot matches a bitbake override bitbake will just copy some garbage to RAUC_SLOT. Not 100% sure though since I've never tested the behavior.

The different separator is pretty much a semantic choice. Is the suffix an overload for the variable or is it part of the variable itself? E.g. PREFERRED_PROVIDER_<recipe> seems to use the underscore separator so I honestly don't even know if the separator should be changed.

tlammi avatar May 12 '22 13:05 tlammi

To get back on this: @tlammi I would also say that it is comparable to PREFERRED_PROVIDER_<recipe>. And it is not comparable to the use of overrides since RAUC_SLOT_rootfs, RAUC_SLOT_boot, etc. are different variables and not variants of the same variable RAUC_SLOT.

As you've already come to a similar conclusion, I guess it would be fine to close this issue now.

ejoerns avatar Dec 07 '23 07:12 ejoerns