cordova-plugin-admob-free icon indicating copy to clipboard operation
cordova-plugin-admob-free copied to clipboard

(android) added bannerHeight to banner LOAD event (#361)

Open syonip opened this issue 6 years ago • 8 comments

Same change implemented on android

syonip avatar Jun 29 '19 12:06 syonip

Hi, any progress on this?

syonip avatar Aug 02 '19 16:08 syonip

please merge this fix!! it's extremely helpful!

pipboy9000 avatar Aug 17 '19 09:08 pipboy9000

please merge.. I need it

123dma avatar Aug 23 '19 12:08 123dma

What does it help with?

aabdolla avatar Oct 13 '19 18:10 aabdolla

having the height in the LOAD event is very useful since the height varies, it saves doing unnecessary calculations for the layout after the the banner is loaded

pipboy9000 avatar Oct 16 '19 12:10 pipboy9000

Hi, needed also here. I have a jquery cordova app that needs to be properly resized and if banner is shown I loose bottom buttons...

luigi37 avatar Jan 29 '20 22:01 luigi37

Any progress on this?

junbonglee avatar Apr 10 '20 08:04 junbonglee

Just noticed if I test on a device running API 30 or API R the banner height that gets returned is actually the device height (so in this case 14400) - is it just me or are others seeing the same issue? Any ideas?

loadUrl(javascript:cordova.fireDocumentEvent('admob.banner.events.LOAD',{"bannerHeight":14400});)

f18nfz avatar Jul 03 '20 12:07 f18nfz