metagraph
metagraph copied to clipboard
ratschlab
Using SSHash submodule for graph representation
Added the SSHash data structure as an option for the DBG representation, implemented using SSHash as a submodule.
[ FAILED ] 10 tests, listed below:
[ FAILED ] DeBruijnGraphTest/4.CallStartNodes, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.CallUnitigsWithoutTips, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.CallUnitigsWithoutTips2, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.CallUnitigsCheckDegree, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.CallUnitigsCross, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.get_maximum_indegree, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.get_degree2, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.indegree_identity_incoming_indegree, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.indegree_identity_traverse_back_incoming, where TypeParam = mtg::graph::DBGSSHash
[ FAILED ] DeBruijnGraphTest/4.CallOutgoingEdges, where TypeParam = mtg::graph::DBGSSHash
10 FAILED TESTS
Are these the same tests that were disabled, or is it something new?
[ FAILED ] 10 tests, listed below: [ FAILED ] DeBruijnGraphTest/4.CallStartNodes, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.CallUnitigsWithoutTips, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.CallUnitigsWithoutTips2, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.CallUnitigsCheckDegree, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.CallUnitigsCross, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.get_maximum_indegree, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.get_degree2, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.indegree_identity_incoming_indegree, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.indegree_identity_traverse_back_incoming, where TypeParam = mtg::graph::DBGSSHash [ FAILED ] DeBruijnGraphTest/4.CallOutgoingEdges, where TypeParam = mtg::graph::DBGSSHash 10 FAILED TESTSAre these the same tests that were disabled, or is it something new?
DeBruijnGraphTest/4.CallStartNodes seems to SegFault because of a multi-threading issue. This goes away if I change its hard-coding from 8 threads to 1
@hmusta hi, what's the current plan with this PR? As in, who should work on it at this point? I can try to implement the stuff that I suggested in the review, but I think I still need some input on some of the comments, esp. https://github.com/ratschlab/metagraph/pull/481#discussion_r1629606622.