ratrun
ratrun
I think that one also needs to take the transportation mode into regard. See https://github.com/graphhopper/graphhopper/compare/master...ratrun:biketourplanner:issue2982 for a draft
> Don't we already return `restrictionKeys` based on transportation mode? Yes, you are right. Thank you! I now simplified my change and created a PR, see #3018
This issue can be closed, the provided examples are working.
> Why do we treat cycleway as special? Shouldn't we allow vehicle=no for all highway values? Yes, you are right. Thanks! I'll update. Reduction to walking speed is included now
Please recheck. I think that all requested improvements are included now.
> bicycle=no should probably also be included in the fallback to pushing. Not sure how often it occurs, but should that fallback branch check if walking is allowed? No, I...
> > Why do we treat cycleway as special? Shouldn't we allow vehicle=no for all highway values? > > Yes, you are right. Thanks! I'll update. > Looking at the...
> But that means we have to assume walking speed and display a dismount warning. I forgot about this recent cool feature. With this functionality my previous concerns are not...
> Could we further avoid this? Maybe e.g. avoid the cases where `get_off_bike==true` in the custom model bike.json? I think that this would require to change the `BooleanEncodedValue` of `GetOffBike`...
> Being told to get off the bike by a traffic sign and voluntarily switching to pedestrian are two different things and should be treated as such. I'm not sure...