Add ReportMetrics to azureidentity.go

Open shahramk64 opened this issue 1 year ago • 5 comments

ReportMetrics is already used in azureqorkloadidentity.go. To provide parity between the two auth providers, ReportMetrics should be added to azureidentity.go too.

Oct 15 '24 05:10 shahramk64

/assign

Oct 15 '24 06:10 SpongeBob0318

@SpongeBob0318 Thanks for working on this issue. It seems like you closed the PR, do you need any help to continue your work so you can make this PR ready to merge?

Oct 17 '24 00:10 shahramk64

@SpongeBob0318感谢您处理此问题。您似乎关闭了 PR，您需要任何帮助来继续您的工作，以便让此 PR 准备好合并吗？

I'm not sure if my modifications are correct, Codecov was unsuccessful when I submitted the PR

Oct 17 '24 01:10 SpongeBob0318

@SpongeBob0318 I'll add some comments on your PR on how you can pass Codecov action.

Oct 17 '24 01:10 shahramk64

@SpongeBob0318 I'll add some comments on your PR on how you can pass Codecov action.

thank you, i have reopen it

Oct 17 '24 01:10 SpongeBob0318