rathena icon indicating copy to clipboard operation
rathena copied to clipboard

Adds Spirit Handler to Summoner checks

Open aleos89 opened this issue 2 years ago • 13 comments

  • Addressed Issue(s): Fixes #7039

  • Server Mode: Renewal

  • Description of Pull Request:

    • Adds the Spirit Handler job to the basic Summoner job checks. Thanks to @laziem!

aleos89 avatar Jun 27 '22 14:06 aleos89

I just tried this, and the problem of asking for 118 skill points still continues, I think something is missing

SpartanGmes avatar Jun 27 '22 15:06 SpartanGmes

add else { return MAPID_SPIRIT_HANDLER; }

below if( skill_point < summoner_skills ){ return MAPID_SUMMONER; }

at pc_calc_skilltree_normalize_job_sub pc.cpp

laziem avatar Jun 27 '22 16:06 laziem

This pull request introduces 3 alerts when merging 549b3003957178353e830f1dd6cef3cd2dd81e48 into 17d6381901197c4687ec0fb3eb420a429d2cda45 - view on LGTM.com

new alerts:

  • 3 for Comparison result is always the same

lgtm-com[bot] avatar Jun 27 '22 18:06 lgtm-com[bot]

It seems like a joke, but now all the jobs are damaged XD! they do not allow any skill to upload and in extras they put doram skills test1

SpartanGmes avatar Jun 27 '22 21:06 SpartanGmes

Restore if( sd->class_ & MAPID_SUMMONER || sd->class_ & MAPID_SPIRIT_HANDLER ){ Into if( sd->class_ & MAPID_SUMMONER ){

laziem avatar Jun 27 '22 22:06 laziem

when updating all the jobs were repaired, but still ask for the 118 skill points in the first branch to be able to upload the hendler spirit

new1

SpartanGmes avatar Jun 30 '22 14:06 SpartanGmes

when updating all the jobs were repaired, but still ask for the 118 skill points in the first branch to be able to upload the hendler spirit

new1 ![new1]

same for me

Benq28021997 avatar Jun 30 '22 14:06 Benq28021997

still the problem persists

SpartanGmes avatar Jul 03 '22 18:07 SpartanGmes

Is the problem still there? Is there a solution?

24msz6eo avatar Jul 16 '22 05:07 24msz6eo

I can confirm this problem. It is not possible to add points to Spirit Handler skills.

To release to add points in Spirit Handler you need to complete all Summoner skills. Probably similar to how the Novice is with the base skill level 10. It's understanding that you need to add all Summoner skills at max level.

Badarosk0 avatar Aug 23 '22 19:08 Badarosk0

i also confirm this issue, even after applying this and having latest rA 😢

OptimusM avatar Sep 27 '22 23:09 OptimusM

with the latest updates it now works correctly. :+1:

SpartanGmes avatar Oct 21 '22 16:10 SpartanGmes

Change : MAPID_SPIRIT_HANDLER = JOBL_UPPER|MAPID_SUMMONER, To : MAPID_SPIRIT_HANDLER = JOBL_FOURTH|JOBL_THIRD|JOBL_UPPER|JOBL_2_1|MAPID_SUMMONER,

src/map/map.hpp

Nicapone1 avatar Mar 27 '24 17:03 Nicapone1