rathena
rathena copied to clipboard
Adds Spirit Handler to Summoner checks
-
Addressed Issue(s): Fixes #7039
-
Server Mode: Renewal
-
Description of Pull Request:
- Adds the Spirit Handler job to the basic Summoner job checks. Thanks to @laziem!
I just tried this, and the problem of asking for 118 skill points still continues, I think something is missing
add
else { return MAPID_SPIRIT_HANDLER; }
below
if( skill_point < summoner_skills ){ return MAPID_SUMMONER; }
at pc_calc_skilltree_normalize_job_sub
pc.cpp
This pull request introduces 3 alerts when merging 549b3003957178353e830f1dd6cef3cd2dd81e48 into 17d6381901197c4687ec0fb3eb420a429d2cda45 - view on LGTM.com
new alerts:
- 3 for Comparison result is always the same
It seems like a joke, but now all the jobs are damaged XD! they do not allow any skill to upload and in extras they put doram skills
Restore if( sd->class_ & MAPID_SUMMONER || sd->class_ & MAPID_SPIRIT_HANDLER ){
Into if( sd->class_ & MAPID_SUMMONER ){
when updating all the jobs were repaired, but still ask for the 118 skill points in the first branch to be able to upload the hendler spirit
when updating all the jobs were repaired, but still ask for the 118 skill points in the first branch to be able to upload the hendler spirit
same for me
still the problem persists
Is the problem still there? Is there a solution?
I can confirm this problem. It is not possible to add points to Spirit Handler skills.
To release to add points in Spirit Handler you need to complete all Summoner skills. Probably similar to how the Novice is with the base skill level 10. It's understanding that you need to add all Summoner skills at max level.
i also confirm this issue, even after applying this and having latest rA 😢
with the latest updates it now works correctly. :+1:
Change : MAPID_SPIRIT_HANDLER = JOBL_UPPER|MAPID_SUMMONER, To : MAPID_SPIRIT_HANDLER = JOBL_FOURTH|JOBL_THIRD|JOBL_UPPER|JOBL_2_1|MAPID_SUMMONER,
src/map/map.hpp