FluxCP icon indicating copy to clipboard operation
FluxCP copied to clipboard

Update for Web Server

Open Balferian opened this issue 3 years ago • 1 comments

Fixes https://github.com/rathena/FluxCP/issues/315 .

Changes proposed in this Pull Request:

  • Allowed to use external db for web server for guild icons.
  • Usage of "EmblemUseWebservice" was removed from modules.
  • Added support for gif with transparent layer.

https://user-images.githubusercontent.com/16213511/191065655-3e394127-76e6-4131-80b3-ebeb0a5140fb.mp4

Balferian avatar Sep 19 '22 14:09 Balferian

Transparent gif with rgb(255, 0, 255) as some fill are displaying as is? Is this intended?

ecdarreola avatar Sep 20 '22 02:09 ecdarreola

please merge this to master

mazvi avatar Nov 08 '22 09:11 mazvi

please merge this to master

@mazvi It`s not completed yet.

Balferian avatar Nov 08 '22 10:11 Balferian

The only way to change the magenta background into transparent and keep the animation I can think of is using imagemagick

Daegaladh avatar Nov 08 '22 13:11 Daegaladh

We don't have to worry about transparency :) no problem not being transparent on the website :D

mazvi avatar Nov 08 '22 23:11 mazvi

The only way to change the magenta background into transparent and keep the animation I can think of is using imagemagick

imagick package is not included by default in php, users may experience problems because of this (not all hosts allow to install packages for php), so I don't want to use imagemagick now. If there is no other way to process GIFs, then we will return to this option (imagemagick) and make it optional.

Balferian avatar Nov 09 '22 09:11 Balferian

Well, php-gd is also an extension and we use it anyway

Maybe you could check for imagemagick and made it optional to show transparency depending on if it's installed or not

Daegaladh avatar Nov 09 '22 09:11 Daegaladh

Any prediction on when this PR will merge? xD

Pokye avatar Nov 02 '23 11:11 Pokye

Any prediction on when this PR will merge? xD

My prediction is February 2024

mazvi avatar Nov 09 '23 19:11 mazvi