mapscii icon indicating copy to clipboard operation
mapscii copied to clipboard

Published 20 hours ago • verified publisher icon rastapasta

Translate to ESM (ECMAScript Module)

Open jaller94 opened this issue 2 years ago • 2 comments

More and more of our dependencies transitioned to ESM.

To keep up with security fixes, it seems that we need to transition to ESM as well.

Merging after 1 week, if no one reviews this.

jaller94 avatar Apr 29 '22 20:04 jaller94

Aloha @jaller94 - thanks for all your updates here, I'm a bit hesitant of merging them right away as I see it more as a decorative update of the code generated by your CoffeeScript converter.

Just to keep you in the loop, MapSCII v2 is slowly progressing in the currently limited free time (with some fundamental refactors for usability of MapSCII from inside other cli applications and a full switch, as already desired back then, to TypeScript). I would recommend limiting the time spent on updating/beautifying the current codebase - next to security patches. Cheers!

rastapasta avatar May 03 '22 09:05 rastapasta

Hi @rastapasta,

all my PRs so far have been hand-translated. I didn't use a converter.

This PR and #117 are pretty good refactors, even if Mapscii 2 is on its way.

jaller94 avatar Feb 26 '23 17:02 jaller94