rpi-imager icon indicating copy to clipboard operation
rpi-imager copied to clipboard

Advanced settings fail silently if no password set

Open chrullrich opened this issue 2 years ago • 4 comments

The advanced settings dialog does not give any useful feedback when it does not save settings on account of the user password field being blank. The only thing I could find is that the field label turns red. There is no error message indicating to the user that their input has actually not been saved. (The save button also sets the input focus to the empty password field, but because the window a) does not bother to scroll that field into view, and b) is needlessly tiny and not resizeable, this nice gesture is frequently lost on the user.)

This is bad UI because the user cannot predict the behavior of the window; it is not clear that the window is supposed to close after clicking "Save" and that it is therefore a sign of trouble when it does not. For some users, manually closing the window after apparently saving the settings may make sense, and there is no prompt to save modified settings when closing the window either.

If the UI was designed more in line with platform standards and put less emphasis on being white, red, and flat, that might be more obvious. Changing the caption of the "Save" button to something that typically indicates the save-and-close operation on the respective platform, such as "OK" on Windows, would also help. The user is going to interact with the UI for a very few minutes before starting a possibly lengthy operation (writing the image). It would be nice of the application to make the utmost effort to ensure the user gets the result they wanted.

chrullrich avatar Jul 16 '23 09:07 chrullrich

Wow.. this remained untouched since 2016!

hagenbuch avatar Oct 10 '23 12:10 hagenbuch

Problem with error messages is that they need to be translated in 15 languages. Red = trouble is pretty universal.

Scrolling issue should no longer be there with tabbed settings window.

maxnet avatar Oct 10 '23 14:10 maxnet

Wow.. this remained untouched since 2016!

If you mouse-hover over the date (where it says "Jul 16") the tooltip says "Jul 16, 2023, 10:58 AM GMT+1", which is much more recent than 2016 :wink:

lurch avatar Oct 12 '23 13:10 lurch

Well I agree! Sorry. Not all countries have the day after the month :)

hagenbuch avatar Oct 12 '23 13:10 hagenbuch

Screenshot 2024-09-18 at 15 33 00

1.9.0 will refuse to let you save, and highlight the field that failed.

tdewey-rpi avatar Sep 18 '24 14:09 tdewey-rpi