pico-sdk icon indicating copy to clipboard operation
pico-sdk copied to clipboard

Header hardware targets depend on hardware_claim_headers

Open ooxi opened this issue 1 year ago • 3 comments

A target created by pico_simple_hardware_headers_target must depend on hardware_claim_headers not hardware_claim.

This avoids adding claim.c to the user sources. If the user wanted claim.c to be added to the sources, the user would have used the targed defined by pico_simple_hardware_impl_target.

This is not an issue for hardware_structs since this target does not define sources.

Fixes #957

ooxi avatar Aug 03 '22 18:08 ooxi

presumably you should now also add hardware_claim as a dependency during pico_simple_hardware_impl_target

kilograham avatar Sep 06 '22 16:09 kilograham

@kilograham thanks for the feedback, I will update the patch accordingly

ooxi avatar Sep 09 '22 17:09 ooxi

@kilograham I have updated the patch accordingly and tested the change in my application

ooxi avatar Sep 10 '22 11:09 ooxi

closed in favor of #1211

kilograham avatar Jan 29 '23 19:01 kilograham