pico-sdk icon indicating copy to clipboard operation
pico-sdk copied to clipboard

Fix incorrect Bazel dependency in host/hardware_irq

Open rhulme opened this issue 1 month ago • 3 comments

Bazel configuration adds a dependency on hardware_claim in 'host' but it doesn't exist there. It's in 'common'.

Fixes #2738

rhulme avatar Nov 30 '25 12:11 rhulme

Thanks! Because of #2596, you might be able to remove tags = ["manual"] from this too

I haven't got my head around how exactly Bazel does things yet. I just tried running the command from the Bazel build checks (which seem to be permanently failing anyway).

I noticed host/hardware_irq still has issues because PICO_NUM_VTABLE_IRQS is not defined. That's not a Bazel issue directly, more a debug/release build issue. It seems that Bazel creates a debug build by default, so the assertion in check_irq_param becomes 'live' and the compiler complains about the undefined value.

rhulme avatar Dec 03 '25 20:12 rhulme

I noticed host/hardware_irq still has issues because PICO_NUM_VTABLE_IRQS is not defined.

More PRs are always welcome! :smile:

lurch avatar Dec 04 '25 09:12 lurch

I noticed host/hardware_irq still has issues because PICO_NUM_VTABLE_IRQS is not defined.

More PRs are always welcome! 😄

I was trying to decide what the "right" way to fix it would be :wink:

rhulme avatar Dec 04 '25 15:12 rhulme