NUM_RESETS is wrong for both rp2040 and rp2350

[peterharperuk]

#define NUM_RESETS _u(24)

It should be 25?

typedef enum reset_num_rp2040 {
...
    RESET_USBCTRL = 24, ///< Select USBCTRL to be reset
    RESET_COUNT
} reset_num_t;

[lurch]

Same thing seems to affect RP2350 too?

But it looks like the only places where NUM_RESETS is used, it's being compared using > rather than >=, which is why I guess this has never caused any problems?

invalid_params_if(HARDWARE_RESETS, block_num > NUM_RESETS);

[peterharperuk]

Yes, it's wrong for rp2350 as well.

[kilograham]

note this is in header generation already, but still needs to be merged