pico-sdk
pico-sdk copied to clipboard
Changes for pico2_w
Changes for Pico 2 W
The changes I made in #1814 are happy with this new header-file :smiley:
I have a question about board naming, in particular whether there's a space in the "Pico" board names or not.
There are currently the following board definition files in this repo:
include/boards/pico.h: #define RASPBERRYPI_PICO
include/boards/pico_w.h: #define RASPBERRYPI_PICO_W
include/boards/pico2.h: #define RASPBERRYPI_PICO2
And then this PR adds:
include/boards/pico2_w.h: #define RASPBERRYPI_PICO2_W
That seems nice and consistent. From MicroPython's side we have the corresponding:
RPI_PICOboard with name"Raspberry Pi Pico"RPI_PICO_Wboard with name"Raspberry Pi Pico W"RPI_PICO2board with name"Raspberry Pi Pico2"
And then I guess we would add:
RPI_PICO2_Wboard with name"Raspberry Pi Pico2 W"
The board name matters because that's the name of the source directory, eg ports/rp2/boards/RPI_PICO2. And also the name of the firmware, eg RPI_PICO2-20240816-v1.23.x.uf2.
My main question is whether there should be a space between "Pico" and "2", because:
- it's referred to as "Raspberry Pi Pico 2" in almost all locations (with a space between "Pico" and "2"), for example in the RP2350 and Pico 2 datasheets
- the datasheet for Pico 2 is called
pico-2-datasheet.pdf, ie there's a hyphen between the "pico" and "2" - the URL is https://www.raspberrypi.com/products/raspberry-pi-pico-2/, ie has a hyphen
So that seems a little inconsistent, whether there's a space or not between the "Pico" and the "2", and then that would follow for the "Pico 2 W" (vs "Pico2 W").
I know this is a minor point, but we'd like to get the names correct in MicroPython so the board names, firmware names and download URL are correct and don't need to change in the future.
Should we call our boards:
RPI_PICO2andRPI_PICO2_W- or
RPI_PICO_2andRPI_PICO_2_W?
Our board header files have...
#ifndef _BOARDS_PICO2_H
#define _BOARDS_PICO2_H
// For board detection
#define RASPBERRYPI_PICO2
So I think PICO2_W is consistent. I seriously considered PICO2W but that's inconsistent with PICO_W which doesn't quite work as PICOW. I'll ask around if there's a policy
Later: Officially, it's "Pico 2" and "Pico 2 W" with spaces. But I think we should leave things as they are.
@kilograham I think I resolved all the review comments in this.