pico-sdk icon indicating copy to clipboard operation
pico-sdk copied to clipboard

Fix minor unused/uninitialized warnings from GCC 12.3.0

Open earlephilhower opened this issue 1 year ago • 2 comments

Decorate an unused parameter in the timer API and fill in all structure elements in a PIO API call that generate warnings under GCC 12.

Fixes #1785

earlephilhower avatar Aug 09 '24 00:08 earlephilhower

Looks good

peterharperuk avatar Aug 09 '24 16:08 peterharperuk

An ok - I had wondered if this was a c++ thing - the {0} is valid C but had seen reports of some versions (albeit old) reporting that exact message

kilograham avatar Aug 21 '24 01:08 kilograham

I had forgot about that simpler {} solution! Updated with the change and I can confirm no warnings generated for it in the latest G++s.

earlephilhower avatar Nov 14 '24 16:11 earlephilhower

As this is now a one-character change, it might be worth squashing the commits?

lurch avatar Nov 14 '24 18:11 lurch

Done, thx!

earlephilhower avatar Nov 14 '24 18:11 earlephilhower