pico-sdk icon indicating copy to clipboard operation
pico-sdk copied to clipboard

ability to set git tag to download in external/pico_sdk_import.cmake

Open ahmetkizilay opened this issue 1 year ago • 3 comments

it would be useful to lock the release/tag for projects that depends on the pico-sdk.

We can use PICO_SDK_FETCH_GIT_TAG to specify a release tag for the Pico SDK to download.

example usage:

set(PICO_SDK_FETCH_FROM_GIT true)
set(PICO_SDK_FETCH_FROM_GIT_TAG "1.5.1")
include(pico_sdk_import.cmake)

ahmetkizilay avatar Feb 08 '24 02:02 ahmetkizilay

I don't think we'd use it. master is always the latest release

peterharperuk avatar Feb 08 '24 09:02 peterharperuk

I guess the implied usage-model here is for people who are copying pico_sdk_import.cmake into their own project, and want to pin to specific version of pico-sdk, so that their project doesn't get accidentally broken by later pico-sdk updates?

lurch avatar Feb 08 '24 12:02 lurch

That would make some sense I guess. Although isn't that what git submodules are for?

peterharperuk avatar Feb 08 '24 15:02 peterharperuk