pico-sdk icon indicating copy to clipboard operation
pico-sdk copied to clipboard

Incorrect argument to gpio_add_raw_irq_handler_with_order_priority() in pico_cyw43_arch

Open esky-software opened this issue 3 years ago • 1 comments

The following files in pico_cyw43_arch:

cyw43_arch_poll.c cyw43_arch_threadsafe_background.c cyw43_arch_freertos.c

each install a GPIO interrupt handler via the following call:

gpio_add_raw_irq_handler_with_order_priority(IO_IRQ_BANK0, gpio_irq_handler, CYW43_GPIO_IRQ_HANDLER_PRIORITY);

The first argument IO_IRQ_BANK0 identifies the IRQ number for the GPIO interrupt - but the function actually expects the specific GPIO number for which to install the handler.

i.e. The argument IO_IRQ_BANK0 should be replaced with CYW43_PIN_WL_HOST_WAKE

esky-software avatar Sep 06 '22 12:09 esky-software

ping @peterharperuk

lurch avatar Sep 06 '22 13:09 lurch

Fixed by #1069

envirocoder avatar Oct 28 '22 15:10 envirocoder

should be fixed by #1177

kilograham avatar Jan 18 '23 01:01 kilograham

merged into develop

kilograham avatar Jan 24 '23 18:01 kilograham