pico-examples icon indicating copy to clipboard operation
pico-examples copied to clipboard

BTstack prepare for packet logs

Open mringwal opened this issue 1 year ago • 7 comments

When users have problems, the most efficient way is to analyze the packet logs. This PR makes it easier to enable the packet logger.

mringwal avatar Oct 03 '23 12:10 mringwal

I'll switch this to develop if you don't mind.

peterharperuk avatar Oct 03 '23 12:10 peterharperuk

Sorry, both should have been for 'develop'

mringwal avatar Oct 03 '23 12:10 mringwal

We do some of this in the sdk https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/pico_cyw43_driver/btstack_cyw43.c#L54 where we also check ENABLE_SEGGER_RTT. Maybe we should call hci_dump_enable_packet_log in there as well?

peterharperuk avatar Oct 03 '23 12:10 peterharperuk

I see. In this case, we can close this PR. The logger is on by default, so that's fine, too.

The point is, how would people (incl. me) find this?

mringwal avatar Oct 03 '23 12:10 mringwal

Maybe I should add a README for the bluetooth examples? The macro is commented out here https://github.com/raspberrypi/pico-examples/blob/master/pico_w/bt/CMakeLists.txt#L53

peterharperuk avatar Oct 03 '23 12:10 peterharperuk

A README would be great!

mringwal avatar Oct 03 '23 12:10 mringwal

Is this any good? https://github.com/raspberrypi/pico-examples/pull/427

peterharperuk avatar Oct 03 '23 14:10 peterharperuk