pico-examples icon indicating copy to clipboard operation
pico-examples copied to clipboard

Published 20 hours ago • verified publisher icon raspberrypi

Refactor the oled_i2c example

Open JamesH65 opened this issue 2 years ago • 3 comments

This PR does a number of things:

  1. Renames the oled_i2c example to ssd1306_i2c to match other example folder names that use the device name
  2. Merge code from another ssd1306 example that was sitting in another PR
  3. Add a few more demo parts to the code for extra fun.
  4. Couple of bug fixes that were reported in original code to fix handling different display sizes, so code now works for 32 and 64 pixel height displays by changing a define at top of code.

JamesH65 avatar May 24 '22 15:05 JamesH65

Can someone review this please? I really like to get this merged.

JamesH65 avatar Jun 27 '22 07:06 JamesH65

Not sure where the conflicts have come from....

JamesH65 avatar Jun 27 '22 07:06 JamesH65

@kilograham @lurch Would be good to get this merged. No idea why it thinks there are merge conflicts. The two files mentioned are moved, not changed.

JamesH65 avatar Oct 14 '22 10:10 JamesH65

@kilograham Can we merge this? Been hanging around a while.

JamesH65 avatar Nov 25 '22 11:11 JamesH65

Fixed the merge conflict.

JamesH65 avatar Nov 25 '22 12:11 JamesH65

you didn't update the README.md (which has a link)

Ooh, good spot, pushed a fix.

JamesH65 avatar Nov 25 '22 16:11 JamesH65

you didn't update the README.md (which has a link)

Ooh, good spot, pushed a fix.

Yeah everyone seems to forget the README, so I always check!

kilograham avatar Nov 25 '22 16:11 kilograham

Also found another PR that was based on the old OLED example, so just fixed and pushed that to the refactor as well. https://github.com/raspberrypi/pico-examples/pull/284

JamesH65 avatar Nov 25 '22 16:11 JamesH65