Async Call Cleanup
There are a number of functions designed to be call by the camera event loop which are dispatched asynchronously. They all return things of the form (True, return_value) so I pulled out the boolean, as that always evaluates true.
Along the way, I:
- added some typing information
- tidied up some bound locals that didn't need to be passed into closured functions explicitly.
- Added position indication to lint errors.
Gentle poke for thoughts @davidplowman
Hi, thanks for submitting this. Would it be possible to split the various addressed here into separate PRs in accordance with our contribution guidelines? That way we could get some of the straightforward issues merged more quickly and leave us free to discuss other things without them being mixed up with other changes. Thanks!
I can do that. I usually just add typing as I need to get my IDE type-checks to come up happy. GIven the diff size of <100 LOC I figured this wouldn't matter terribly. I will reopen it as ~3PRs later today.
I opted to break it into 3 PR's. When you get a chance if you get #359 and #358 I can rebase/squash/sign the remaining bits here.
@davidplowman when the two above go in, I will rebase this one.
Moved to #375