noobs icon indicating copy to clipboard operation
noobs copied to clipboard

Support query params in tarball urls

Open digitalLumberjack opened this issue 8 years ago • 6 comments

Hi!

Tarballs urls may contain http query params, but an url like https://mydistribution.com/root.tar.xz?source=noobs cannot be processed as MultiImageWriteThread::untar check the file extension without taking in account query params.

digitalLumberjack avatar Aug 17 '17 12:08 digitalLumberjack

How likely is it for a tarball URL to end with a query param? :confused:

lurch avatar Apr 26 '18 22:04 lurch

@lurch, it's not so much that it's likely, but that it would be nice to give maintainers some flexibility. For example, they may want to track where their downloads are coming from.

The reason this hasn't been done is that it wouldn't work with older versions of NOOBS. We'd need an os_list_v4.json or an additional query parameter in os.json.

XECDesign avatar Apr 27 '18 09:04 XECDesign

Given how NOOBS-specific these downloads are, it's hard to imagine them coming from anywhere other then NOOBS? :wink:

Unless a future version of NOOBS itself (automatically) added these query-strings, e.g. http://downloads.raspberrypi.org/raspbian_lite/boot.tar.xz?noobs=v2.8.1&rpi=3B so that maintainers could see which versions of NOOBS and which models of RPi are downloading their distros? (which is obviously a separate discussion)

lurch avatar Apr 27 '18 10:04 lurch

Given how NOOBS-specific these downloads are, it's hard to imagine them coming from anywhere other then NOOBS?

OP maintains Recalbox, so I bet there's a reason for asking. Perhaps the same files are used by the built-in updater or as a part of an alternative install method.

XECDesign avatar Apr 27 '18 10:04 XECDesign

Ahhh, so perhaps my previous example should be expanded to something like: http://downloads.raspberrypi.org/raspbian_lite/boot.tar.xz?downloader=noobs&downloader_version=2.8.1&platform=RaspberryPi&platform_model=3B

:man_shrugging:

But as you say, that still wouldn't keep track of downloads by NOOBS <= 2.8

lurch avatar Apr 27 '18 10:04 lurch

Hi, you are right we used same files for noobs install and recalbox internal upgrade process, and we wanted to specify the source with a query param in order to manage our kibana download dashboard based on nginx and haproxy logs :)

digitalLumberjack avatar Apr 27 '18 15:04 digitalLumberjack