noobs icon indicating copy to clipboard operation
noobs copied to clipboard

Allow OS maintainer to use their own video mode settings. Fixes #259

Open samnazarko opened this issue 9 years ago • 8 comments

This should resolve #259.

  • This lets the OS maintainer define "managevideo": "1" in the os.json file if they wish to handle the video modes.
  • If this value is not set, or the value is 0, the old behaviour will be unchanged and the 'videomode' from the QVariantMap will be used to populate the config.txt accordingly.

samnazarko avatar May 24 '15 04:05 samnazarko

@lurch Have you had a chance to look at this yet?

samnazarko avatar Jul 08 '15 10:07 samnazarko

Nope, been too busy with other stuff, sorry.

lurch avatar Jul 08 '15 10:07 lurch

I've updated the patch and merged it into my personal nicohood branch. https://github.com/raspberrypi/noobs/commit/59d14960dabcf75ea786c5df5c0373e558b0fcfd

Ive tested it and it works fine. I really like the idea, since noobs always gets in the way of my monitor settings.

Do not merge this PR, it requires some more changes that I made in my commit. Please refer to the commit above instead.

NicoHood avatar Feb 06 '16 16:02 NicoHood

I can update my original commit to include your changes.

samnazarko avatar Feb 06 '16 16:02 samnazarko

Please do so. I really like to see this one merged.

NicoHood avatar Feb 06 '16 16:02 NicoHood

I have updated my PR against master.

samnazarko avatar Feb 06 '16 17:02 samnazarko

You forgot to declare bool _managevideo;. Have a look at my commit again ;)

NicoHood avatar Feb 06 '16 17:02 NicoHood

Updated now. Did this in a hurry so have not compile tested.

samnazarko avatar Feb 06 '16 20:02 samnazarko