linux icon indicating copy to clipboard operation
linux copied to clipboard

lanes parameter missing for a few ili9881c_desc like nwe080

Open berkutta opened this issue 8 months ago • 3 comments

Describe the bug

On rpi-6.6.y the nwe080 description have the lanes parameter set to 4: https://github.com/raspberrypi/linux/blob/rpi-6.6.y/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c#L2044-L2050

On rpi-6.12.y, this parameters is missing: https://github.com/raspberrypi/linux/blob/rpi-6.12.y/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c#L2506-L2511

Without lanes being specified, the display doesn't work.

Steps to reproduce the behaviour

  • rpi-6.6.y working
  • rpi-6.12.y not working
  • rpi-6.6.y with added lanes working

Device (s)

Raspberry Pi CM4

System

Raspbian

Logs

No response

Additional context

No response

berkutta avatar May 15 '25 15:05 berkutta

I'm running into this issue too, looks like a merge issue as the RPi devs created their kernel 6.12. The panel nwe080 is not present in the upstream kernel: https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c

So, the RPi devs will need to keep merging their panel configs each time they pull from upstream. It makes sense why the parameter might be missing in the 6.12 release here.

If I get the time later, I will put a pull request on this repo to just re-add the missing lanes parameter from all the panels in this driver.

jack-obrien avatar Aug 04 '25 07:08 jack-obrien

Sorry, I missed this one when it was first opened.

Whilst Raspberry Pi accept PRs for third party hardware (nwe080 was added for CutiePi https://github.com/raspberrypi/linux/pull/4742) and will do the basic forward porting of the drivers, we do NOT take on full responsibility for maintaining or necessarily testing it (in many cases we don't have hardware to test with). If there are major issues in forward porting to a new kernel version, then drivers will get dropped and kicked back to the original contributor to fix.

PRs to fix up forward porting errors are welcome, as is upstreaming of patches (there's no reason nwe080 couldn't go upstream).

6by9 avatar Aug 04 '25 10:08 6by9

Yes, I have tested on my panel that the lanes parameter is still needed. Will get a PR ready soon!

jack-obrien avatar Aug 05 '25 05:08 jack-obrien