linux icon indicating copy to clipboard operation
linux copied to clipboard

Update TSC2007 to common touch axis handling

Open timonsku opened this issue 2 years ago • 2 comments

The driver currently lacks most of the essential configuration properties like invert, swap, min max values etc. This adds support for the common handling of these values via touchscreen.yaml. I also removed/updated some of the old vendor specific properties that can be covered via the generic touchscreen.yaml

timonsku avatar Dec 14 '23 02:12 timonsku

cc @makermelissa

ladyada avatar Dec 21 '23 15:12 ladyada

Sorry, stuff happened on my end as well. Thank your for the feedback and review!

DT bindings are ABI, so you can't break existing users. Renaming parameters will cause regressions.

Right that is true. How is this typically handled, do old driver just never get updated or should it support both old and new bindings?

You've put yourself as maintainer in the binding - update MAINTAINERS too?

I was really unsure how this is handled and haven't found guidance on how things would look if something did not have a yaml binding before. Should I put myself as a maintainer there? It felt off to put the current driver maintainer in there if they haven't authored the yaml binding.

This is an unmodified driver from mainline, so I'm afraid we really do have to point you to upstream for a proper review and merge. We'll happily backport an accepted patch, but can't really take on the maintenance burden.

That I don't fully understood, could you expand what you mean with unmodified driver from mainline? Last time I asked the policy was that existing drivers could get a modifications accepted directly without going through mainline first and completely new drivers would have to go through mainline first. Did I misunderstand that?

timonsku avatar Mar 14 '24 17:03 timonsku