debugprobe icon indicating copy to clipboard operation
debugprobe copied to clipboard

5 files missing license header

Open recursivenomad opened this issue 1 year ago • 1 comments

The following files do not contain license information, and therefore cannot be forked/included in other projects:

As this has happened before (#5), it may be worth considering a license file in the root of the repository to serve as a fallback license for future files which lack license headers.

Edit

Build files are also missing license information:

recursivenomad avatar Jun 17 '24 13:06 recursivenomad

I have begun working on a derivative work and would like to use probe_oen.pio in it, however its lack of license header (and the project's lack of a root license file) means the code is "all rights reserved" and unable to legally be reused.

Although the file would be straightforward to recreate with clean-room design, I would prefer to be able to use and contribute back to the original file if possible.

recursivenomad avatar Aug 14 '24 11:08 recursivenomad

FreeRTOS_Kernel_import.cmake and pico_sdk_import.cmake are direct copies from the pico-sdk, which is BSD 3-clause, so I will add a header to those. probe_config.c and probe_oen.pio are third-party contributions, and attribution/licence has been requested. There are other contributors to cmakelists.txt and I willl CC them in the next comment.

All other files have a licence header - originally the project was designated MIT licenced, and going forward we'll specify that.

Edit: the FreeRTOS_Kernel_import.cmake file is redundant and removed as it is now pulled in directly from the submodule.

P33M avatar Nov 13 '24 09:11 P33M

@a-pushkin @newbrain @rewolff @fduxiao thank you for your contributions to this project, however we have a request.

Some of your edits were to the file CMakeLists.txt and this file was not tagged with an OSS licence (and neither was the overall project). Please confirm that you are the original authors of your work and that you are happy to contribute on the basis that this file is MIT licenced.

https://opensource.org/license/mit

P33M avatar Nov 13 '24 10:11 P33M

I hereby declare that my contributions to this project can be included in this project and distributed and used under the licence that this project is licenced under, in this case the so-called MIT licence.

rewolff avatar Nov 13 '24 12:11 rewolff

@rewolff Thanks for confirming.

probe_oen.pio attribution has been resolved in https://github.com/raspberrypi/debugprobe/commit/9aed4ca509bbe0dc5a60358b51717e37fa72060e pico_sdk_import.cmake has been clarified as to the original file's license in 8f5d6fc

I will ping the other authors again...

P33M avatar Nov 20 '24 11:11 P33M

My contributions can be used and distributed according to the MIT license or any OSI registered form of the BSD license. Please let me know if further action is needed on my part.

newbrain avatar Nov 20 '24 13:11 newbrain

My work is on my own and can be used or distributed under those licenses.

fduxiao avatar Nov 21 '24 01:11 fduxiao

@a-pushkin Sorry to nag! We'd really like to hear back from you?

chrisboross avatar Nov 25 '24 22:11 chrisboross

I have removed the remaining unattributed lines surviving in the project, asked @andygpz11 to do a cleanroom reimplementation of the missing functionality, and have tagged it as MIT licensed. https://github.com/raspberrypi/debugprobe/commit/65b1e73589f7248a6208b0bdcc32c8b8e7e169ee

Thanks to those for confirming that their work is OSS.

P33M avatar Nov 27 '24 11:11 P33M