beepr icon indicating copy to clipboard operation
beepr copied to clipboard

add chocobo wark and hallelujah chorus

Open Myfanwy opened this issue 8 years ago • 2 comments
trafficstars

Not sure if you’re accepting new sounds to the beepr package, but I thought it would be fun to try! The sounds worked on my machine…but this is the first real pull request I’ve made, so there might be other compatibility issues.

Myfanwy avatar Sep 12 '17 19:09 Myfanwy

So, I'm trying to resist to add new sounds to beepr to keep the package small. But these are really good sounds! I'll have to think about it a little bit... But thanks for the nice pull request! 😄

rasmusab avatar Sep 15 '17 09:09 rasmusab

Oh I understand, no worries! It was a mostly a good learning exercise for me. I can definitely understand wanting to keep the package small, or you'd never see the end of the PRs 😊

On Fri, Sep 15, 2017, 2:33 AM Rasmus Bååth [email protected] wrote:

So, I'm trying to resist to add new sounds to beepr to keep the package small. But these are really good sounds! I'll have to think about it a little bit... But thanks for the nice pull request! 😄

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rasmusab/beepr/pull/17#issuecomment-329731956, or mute the thread https://github.com/notifications/unsubscribe-auth/AGN63_VFaeT0NKOIUvKo9GeXaK7GA6Ecks5sikRcgaJpZM4PVIkz .

--

Myfanwy Johnston, Ph.D Cramer Fish Sciences 530.240.6112


I welcome VSRE emails. Learn more at http://vsre.info/

Myfanwy avatar Sep 15 '17 14:09 Myfanwy