socket.io-php-emitter
socket.io-php-emitter copied to clipboard
Feature/php tidy
- I tried to tidy up the PHP a bit here in line with spec.
- I'm still a little unsure as to why the key string or what I see as the event namespace was so hardcoded, i'm not an expert so perhaps you could clarify. I've changed the structure and readme in-line with how I believe it could work better.
- Tabs to 4 spaces
- Constants to class variables
- Block comments
- Emit arguments passed inline rather than stripped out of the args
It should in essence not change the way the class already works, just tidies it up. Let me know what you think...
Thanks for the PR!
I like moving the constants and doc comments, but I'm not very fond of tab spacing or newline before {, for example.
Could you maybe suggest these changes in smaller pieces?
@rase- This would be awesome for your library. I know that following the PSR standards can be weird at first, but you will get the hang of it. :+1: for the PR.
src/binary.php file names should use StudlyCase, therefore src/Binary.php.