fixed_features for ExhaustiveFeatureSelector #579

[Junting-Wang]

add fixed_features

Description

Related issues or pull requests

Pull Request Checklist

• [ ] Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
• [ ] Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
• [ ] Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
• [ ] Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
• [ ] Checked for style issues by running flake8 ./mlxtend

[pep8speaks]

Hello @Junting-Wang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file mlxtend/feature_selection/exhaustive_feature_selector.py:

Line 337:35: E127 continuation line over-indented for visual indent Line 338:35: E127 continuation line over-indented for visual indent

Comment last updated at 2019-12-29 14:58:02 UTC

[rasbt]

Hi Junting. I just did a rebase because there were some issues in the continuous integration service. Based on the recent tests, it looks like your code still has errors.

[NimaSarajpoor]

@rasbt I just noticed that this PR was initially opened in 2019! I did a review. It would be great if you could take a look and see if they make sense or not.

@Junting-Wang Are you planning to continue your work? If not, I can continue this work.

[rasbt]

Hi @NimaSarajpoor thanks for finding this old PR. Yes, fixed_features are already in the SequentialFeatureSelector but not in the ExhaustiveFeatureSelector, and it would be awesome to have it.

I am pretty sure Junting is probably not going to continue this. If you would take a crack at it, that'd be awesome.

PS: I am super sorry about the slow response times (saw a notification about your other PR but haven't had a chance to look at it yet -- attending 2 conferences this week and there was a lots that need(ed) to get done)!

[NimaSarajpoor]

Yes, fixed_features are already in the SequentialFeatureSelector but not in the ExhaustiveFeatureSelector, and it would be awesome to have it.

Good to know! I didn't know this feature is supported in SequentialFeatureSelector. I will take a look.

am pretty sure Junting is probably not going to continue this. If you would take a crack at it, that'd be awesome.

I haven't worked with an already-existing PR before. I might seek help if I cannot figure out how to pull it to my local repo.

PS: I am super sorry about the slow response times (saw a notification about your other PR but haven't had a chance to look at it yet -- attending 2 conferences this week and there was a lots that need(ed) to get done)!

No worries at all. I have been busy with writing my thesis as well :) So, all good :)

[NimaSarajpoor]

@rasbt You may want to close this.

[rasbt]

Yup, thanks :)