Sebastian Raschka comments

Results 846 comments of


                                            Sebastian Raschka

Do not wrap LoRA layers with FSDP

I haven't looked into the implementations (and even explanations), but just a spontaneous thought that we should perhaps retry this with FSDPv2

numpy 2.0.0 support

Thanks for the note. I'll pin `numpy==1.26.4 ` for now and then investigate further regarding the changes in the NumPy 2.0 release this week.

numpy 2.0.0 support

I can echo this and would say let's wait at least a month before we revisit this to give all the dependencies time to catch up.

converting llama models

Hi there. Sorry to hear that the approval is such a hassle. It seems there must be an issue on their website as it should usually be close to immediate....

BERT score: maximum at self-comparison, symmetry, invariance to additional items

As far as I know, it should be symmetrical for the F1 score. So things like ``` AssertionError: f1 score for ('hello there', 'general kenobi') is not the same as...

Ch 8, applying preprocessor to dataframe type-error

Thanks for the note, and sorry for the late follow-up! I do think your modification would correctly fix issues where the "review" is a float. But I think there may...