LLMs-from-scratch icon indicating copy to clipboard operation
LLMs-from-scratch copied to clipboard

Issue 1: Typo in function docstring

Open PrinceSajjadHussain opened this issue 6 months ago • 7 comments

Body: In the get_requirements_dict function, the docstring has a typo. The word "packaging.requirements.Requirement" should be "packaging.requirements.Requirement".

PrinceSajjadHussain avatar Jun 20 '25 19:06 PrinceSajjadHussain

The docstring in the get_requirements_dict function had a redundant and incorrect phrasing for the return type. I've corrected it to properly describe the return value as:

dict[str, packaging.requirements.Requirement]

The updated docstring now accurately reflects that the values are Requirement objects from the packaging.requirements module, and the duplication has been removed for clarity.

Let me know if you'd like me to open a PR with this fix!

VINEAY avatar Jun 20 '25 21:06 VINEAY

perrfect open a PR

PrinceSajjadHussain avatar Jun 20 '25 21:06 PrinceSajjadHussain

@VINEAY

PrinceSajjadHussain avatar Jun 21 '25 05:06 PrinceSajjadHussain

Hey it's giving an error that Pull request creation failed. Validation failed: must be a collaborator

VINEAY avatar Jun 21 '25 06:06 VINEAY

Thanks for the discussion and suggested improvements.

Hey it's giving an error that Pull request creation failed. Validation failed: must be a collaborator

I think you may have accidentally cloned the repo instead of forking it.

rasbt avatar Jun 22 '25 16:06 rasbt

I have generated a pull request and it's saying that you have collaboration error

VINEAY avatar Jun 22 '25 18:06 VINEAY

I think you made the PR from a clone of the repo instead of a fork of the repo, which is probably why you are seeing that error.

rasbt avatar Jun 22 '25 18:06 rasbt

@rasbt @VINEAY perfect

PrinceSajjadHussain avatar Jun 23 '25 10:06 PrinceSajjadHussain