LLMs-from-scratch icon indicating copy to clipboard operation
LLMs-from-scratch copied to clipboard

fix issue #664 - inverted token and pos emb layers

Open casinca opened this issue 6 months ago • 2 comments

fixes #664

casinca avatar Jun 13 '25 19:06 casinca

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Maybe it would make sense removing everything after encoded_text = tokenizer.encode(raw_text) as it's not relevant for exercise, what do you think @rasbt?

d-kleine avatar Jun 17 '25 12:06 d-kleine

Thanks for the fix @casinca . And I also agree with you @d-kleine , the lines seem redundant and I removed them.

rasbt avatar Jun 22 '25 16:06 rasbt