LLMs-from-scratch icon indicating copy to clipboard operation
LLMs-from-scratch copied to clipboard
verified publisher icon rasbt

Typo / text length

Open d-kleine opened this issue 7 months ago • 2 comments

Bug description

https://github.com/rasbt/LLMs-from-scratch/blob/3f93d73d6dd75aeff21158506afff9500f79c359/ch05/01_main-chapter-code/ch05.ipynb#L816

I assume "words" should be "characters".

Also https://github.com/rasbt/LLMs-from-scratch/blob/3f93d73d6dd75aeff21158506afff9500f79c359/ch05/01_main-chapter-code/ch05.ipynb#L841-L842 and https://github.com/rasbt/LLMs-from-scratch/blob/3f93d73d6dd75aeff21158506afff9500f79c359/ch05/01_main-chapter-code/ch05.ipynb#L867-L868

both print 99 characters, not 100 as explained above

What operating system are you using?

None

Where do you run your code?

None

Environment

No response

d-kleine avatar May 14 '25 19:05 d-kleine

Hey @d-kleine I would like to solve this issue

ajithk1503 avatar Jun 22 '25 07:06 ajithk1503

I was a bit worried that some changes might affect the print version of the book, but I checked and could not find any matches in the text/code there. So, for my part, please feel free to fix this issue, @ajithk1503 🙂

CC @rasbt for visibility/information

d-kleine avatar Jun 22 '25 11:06 d-kleine

Good call @d-kleine . This was fixed in the book itself but I must have forgotten to fix it in the notes here.

rasbt avatar Jun 22 '25 18:06 rasbt