Robert Schumacher

Results 40 comments of Robert Schumacher
trafficstars

> If I didn't miss a symbol, all functions which depend on the JSON selection macros are either in anonymous namespace, or declared static. Looking at the header https://raw.githubusercontent.com/syoyo/tinygltf/6e8a858c4567340919238c21277481f88e14044c/tiny_gltf.h, I...

Some comments on the posted blob that should be considered before merging into vcpkg: - It should be conditional on manifest mode - It should be `BeforeTargets="VcpkgInstallManifestDependencies"` (or that one...

Additionally, the `pagmo2` port patches can be reduced by deleting the lines and not re-adding them as comments: ```diff diff --git a/ports/pagmo2/disable-werror.patch b/ports/pagmo2/disable-werror.patch index 92d930a04..fbbad4785 100644 --- a/ports/pagmo2/disable-werror.patch +++ b/ports/pagmo2/disable-werror.patch...

>This PR can be merged without a clean baseline since the effects of this PR are validated by a single port using MSBuild with cmake instead of Ninja. I'd like...

Yes, let me clarify my position a bit: we don't want to be in the business of attempting to build kernel drivers in vcpkg. We also don't build the CRT,...

I'd recommend using FetchContent instead to grab the entire vcpkg repo. This must be done before the `project()` directive, since vcpkg integration is via `CMAKE_TOOLCHAIN_FILE` which is loaded during `project()`.

To help move this issue forward: it isn't a requirement to support building as a DLL on Windows to be packaged into vcpkg. The recipe can simply add the following...

@emusgrave Not to dissuade the owners from releasing earlier and often-er, but you can install master (if desired) by running `vcpkg install rapidjson --head`.

Reviving this since it was brought up in https://github.com/gtk-rs/gtk4-rs/issues/865. Hi everyone! I'm a maintainer on vcpkg. We'd really like to make it easier for rust to consume C & C++...