FetchXMLBuilder icon indicating copy to clipboard operation
FetchXMLBuilder copied to clipboard

Fix Issue with hidden aggregate fields

Open limitednl opened this issue 3 years ago • 4 comments

Added the option to keep showing aggregate fields on attributes even when the query is not aggregating. See: #789

limitednl avatar Oct 03 '22 11:10 limitednl

Thanks for this PR!

However, I think you are missing a "not" somewhere... If I keep the settings default (Hide fields when aggregating is set) it looks like normal for the attributes. If I uncheck this new setting, aggregate-related properties are never shown.

Are you sure about this feature?

rappen avatar Oct 05 '22 13:10 rappen

You are right! The indended logic was not what was implemented. I fixed it in the seccond commit.

Thb, ive not tested it because i dont know how to set up this project in xrmtoolbox and only made the PR to make a starting point for this feature/fix for you to continue on. I do not know what patterns you use and if the solution i suggested is the way you would have implemented it. I hope it is of some use for you.

limitednl avatar Oct 05 '22 14:10 limitednl

Maybe this can help you on with debug your developments? https://www.xrmtoolbox.com/documentation/for-developers/debug/

rappen avatar Oct 05 '22 14:10 rappen

Thanks for letting me know how to debug the code. For me the code works as intended now. It is up to you to decide what to do with it

limitednl avatar Oct 05 '22 14:10 limitednl