laravel-livewire-tables icon indicating copy to clipboard operation
laravel-livewire-tables copied to clipboard

[Bug] Auto Inject Assets: Only if component rendered

Open yparitcher opened this issue 3 months ago • 6 comments

Regression from 65ce4947ab58b77fb3e454423202edd17e414e49 #1371

Fixes: #1587

Check if component is instanceof DataTableComponent so as not to inject on every livewire page, only ones with a datatable component

All Submissions:

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [ ] Does your submission pass tests and did you add any new tests needed for your feature?
  2. [ ] Did you update all templates (if applicable)?
  3. [ ] Did you add the relevant documentation (if applicable)?
  4. [ ] Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

yparitcher avatar Mar 05 '24 16:03 yparitcher

@lrljoe

yparitcher avatar Mar 05 '24 16:03 yparitcher

Thanks for the tag!

I'll do my absolute best to give it a look tomorrow, as then I'm not about for a week or two.

The injection code needs another update in general as well, as there's some more core stuff that I've not gotten around to merging in from Livewire core just yet, which albeit were minor tweaks.

Also intending to wrap up the code for "public" usage properly in case people do want to publish it and use it that way, but that's probably a month away.

lrljoe avatar Mar 05 '24 23:03 lrljoe

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.14%. Comparing base (6c759e0) to head (44bb82a). Report is 2 commits behind head on develop.

Files Patch % Lines
src/Features/AutoInjectRappasoftAssets.php 75.00% 1 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1683      +/-   ##
=============================================
- Coverage      88.16%   88.14%   -0.03%     
- Complexity      1314     1316       +2     
=============================================
  Files            123      123              
  Lines           3110     3113       +3     
=============================================
+ Hits            2742     2744       +2     
- Misses           368      369       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 05 '24 23:03 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 11 '24 01:04 stale[bot]

@lrljoe ?

yparitcher avatar Apr 17 '24 21:04 yparitcher

Apologies, been a bit busy of late! Will look to get this reviewed and merged in this week.

lrljoe avatar Apr 29 '24 00:04 lrljoe