laravel-livewire-tables icon indicating copy to clipboard operation
laravel-livewire-tables copied to clipboard

WireLinkColumn

Open lrljoe opened this issue 4 months ago • 2 comments

Docs & Tests In Progress

This PR adds in the WireLinkColumn Column Type

This is not ready for merging, as Docs & Tests still need completing.

WireLinkColumn:

  • Removes the requirement for "location()" to be passed (or a callback)
  • Adds in an optional confirmMessage() method integrating with wire:confirm()
  • Adds in a required action() callback, which integrates with wire:click()
  • Maintains optional usage of "attributes() callback for button"

Example

WireLinkColumn::make("Delete With Conf")
  ->title(fn($row) => 'Delete With Conf')
  ->confirmMessage('Test')
  ->action(fn($row) => 'delete("'.$row->id.'")')
  ->attributes(fn($row) => [
      'class' => 'btn btn-danger',
  ]),

All Submissions:

  • [ ] Have you followed the guidelines in our Contributing document?
  • [ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [ ] Does your submission pass tests and did you add any new tests needed for your feature?
  2. [ ] Did you update all templates (if applicable)?
  3. [ ] Did you add the relevant documentation (if applicable)?
  4. [ ] Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

lrljoe avatar Feb 20 '24 00:02 lrljoe

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.11%. Comparing base (bed2130) to head (0868d51). Report is 17 commits behind head on develop.

Files Patch % Lines
src/Views/Traits/Core/HasConfirmation.php 42.85% 4 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1659      +/-   ##
=============================================
- Coverage      88.13%   88.11%   -0.03%     
- Complexity      1310     1321      +11     
=============================================
  Files            123      126       +3     
  Lines           3102     3129      +27     
=============================================
+ Hits            2734     2757      +23     
- Misses           368      372       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 00:02 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 22 '24 01:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 03 '24 04:05 stale[bot]