Upgrade Rust Version

[sjtrny]

Feature Proposed

Since we have pinned to version 1.71.0 we should try to bring the rust version up to something more current.

Ideally we should be in a position to update the rust version as security updates are made to rust.

This unfortunately will require tedious refactoring.

[reneleonhardt]

Glad to hear, but what does it actually mean? 😅

Your dependencies are years old, for example bincode 2 requires MSRV 1.85 and vergen-git2 9 requires MSRV 1.86.

edition 2024 would require at least 1.85, do you want to stay on edition 2021?

Checking rathole's dependencies
name                old req      compatible latest new req
====                =======      ========== ====== =======
async-socks5        0.5          0.5.1      0.6.0  0.6    
base64              0.13         0.13.1     0.22.1 0.22   
bincode             1            1.3.3      2.0.1  2      
clap                3.0          3.2.25     4.5.45 4.5    
console-subscriber  0.1          0.1.10     0.4.1  0.4    
fdlimit             0.2          0.2.1      0.3.0  0.3    
notify              5.0.0-pre.13 5.2.0      8.2.0  8.2.0  
rand                0.8          0.8.5      0.9.2  0.9    
rustls-native-certs 0.7          0.7.3      0.8.1  0.8    
socket2             0.4          0.4.10     0.6.0  0.6    
tokio-rustls        0.25         0.25.0     0.26.2 0.26   
tokio-tungstenite   0.20.1       0.20.1     0.27.0 0.27.0 
toml                0.5          0.5.11     0.9.5  0.9    
vergen              7.4.2        7.5.1      9.0.6  9.0.6

Cargo.lock (cargo)
Total: 14 (LOW: 2, MEDIUM: 10, HIGH: 2)

[sjtrny]

Glad to hear, but what does it actually mean? 😅

Your dependencies are years old, for example bincode 2 requires MSRV 1.85 and vergen-git2 9 requires MSRV 1.86.

Hi Rene, it's not "my" dependencies - it is everyone's. I've made this an issue to hopefully collect feedback from the community before spending a lot of effort. This is a community project and I'm just a maintainer, with relatively little rust experience, so I want to see what people think first.

If you have a preference/recommendation about minimum version or a policy that the project should follow then please feel free to outline it here 🙂.

[sneakers-the-rat]

rust newbie here, i think i must be missing something - i was able to update the rust-toolchain to 1.89.0, run cargo update, and the test still pass without needing to update all the deps. is that not what this issue means?

[byte-sourcerer]

I think that upgrading Rust to the latest stable version is almost always recommended.

[reneleonhardt]

I think that upgrading Rust to the latest stable version is almost always recommended.

For apps like rathole yes, and for CI of course. Libraries like tokio may want to hold back until enough of their dependencies upgraded themselves (declared a higher edition / MSRV).

[HarryPeach]

I'm also wondering what is required for this since it's been mentioned in other tickets as a blocker.

I had no issues compiling and testing with rust 1.92.0 set for edition="2024" and after a cargo update