rmm icon indicating copy to clipboard operation
rmm copied to clipboard

[FEA] Refactor device/runtime APIs in `rmm._cuda.gpu`

Open jakirkham opened this issue 4 years ago • 9 comments

Is your feature request related to a problem? Please describe.

Currently rmm._cuda.gpu contains both device and runtime APIs. Based on discussion ( https://github.com/rapidsai/cudf/pull/4943#pullrequestreview-395881420 ), it would be good to refactor these.

Describe the solution you'd like

Ideally these would be refactored into 2 modules so that users could pull APIs from either one as needed.

Describe alternatives you've considered

Suggestions welcome 🙂

Additional context

NA

jakirkham avatar Apr 20 '20 20:04 jakirkham

The cudf._cuda module has been moved to rmm so transferring issue.

kkraus14 avatar Sep 23 '20 14:09 kkraus14

cc @galipremsagar

jakirkham avatar Sep 23 '20 15:09 jakirkham

Currently rmm._cuda.gpu contains both device and runtime APIs.

Do you mean (CUDA) driver and runtime APIs?

harrism avatar Sep 23 '20 21:09 harrism

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

github-actions[bot] avatar Feb 16 '21 17:02 github-actions[bot]

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

github-actions[bot] avatar Feb 16 '21 17:02 github-actions[bot]

@jakirkham @kkraus14 still relevant?

harrism avatar Feb 16 '21 23:02 harrism

Yes but low priority.

kkraus14 avatar Feb 17 '21 01:02 kkraus14

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Mar 19 '21 01:03 github-actions[bot]

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

github-actions[bot] avatar Nov 18 '21 18:11 github-actions[bot]

I'm going to close this as wontfix. Since this issue was originally created, the advent of cuda-python means that users shouldn't be getting this functionality from rmm anyway, and rmm's implementations have been stripped down thanks to calling cuda-python APIs. At this point rmm_cuda.gpu is a fairly small, internal-only, largely static module. We can reconsider if it needs to expand or move in any way in the future.

vyasr avatar Jun 02 '23 18:06 vyasr