rmm icon indicating copy to clipboard operation
rmm copied to clipboard

[BUG] Conda package for rmm 24.04.00 clobbering files from fmt and spdlog

Open cryos opened this issue 1 year ago • 9 comments

Describe the bug Looking at librmm-24.04.00-cuda12_240410_g8f19c9c3_0.tar.bz from the rapidsai conda channel I see multiple warnings about clobbered files from fmt and spdlog.

Steps/Code to reproduce bug I downloaded https://anaconda.org/rapidsai/librmm/24.04.00/download/linux-64/librmm-24.04.00-cuda12_240410_g8f19c9c3_0.tar.bz2 and untarred, I see multiple files that are installed to paths that conflict such as lib/libfmt.a, lib/libspdlog.a, include/fmt/color.h, include/spdlog/common.h that cause conflicts.

Expected behavior The vendored files should be installed in paths that would not cause conflicts with other packages.

Environment details (please complete the following information):

  • Environment location: [Bare-metal, Docker]
  • Method of RMM install: conda

cryos avatar Apr 11 '24 20:04 cryos

Thanks for filing this. We've been working on improving this systemically across RAPIDS, because this kind of issue pops up in several places. PR #1508 will help us identify issues like this and prevent them going forward. @AyodeAwe @jameslamb If you're able to collaborate on this effort, it would be a great help. I know both of you have expressed interest in this before. Also #1307 is relevant to this for CCCL (another set of headers that are clobbered by a few RAPIDS packages).

bdice avatar Apr 13 '24 17:04 bdice

Thanks for the @! Linked to this on #1508, we're working on this there.

jameslamb avatar Apr 19 '24 21:04 jameslamb

I see that #1508 "contributes to" fixing this issue. What is needed to fully fix it?

harrism avatar Apr 22 '24 21:04 harrism

What is needed to fully fix it?

I'm still investigating that. By the time I move #1508 out of draft and put it up for review, hopefully we'll be able to change "contributes" to "fixes". Will post updates there as I go.

jameslamb avatar Apr 22 '24 21:04 jameslamb

Oh, I just realized it isn't currently in draft. That's an oversight... I just moved it there.

jameslamb avatar Apr 22 '24 21:04 jameslamb

Subscribe to https://github.com/rapidsai/build-planning/issues/54 and https://github.com/rapidsai/build-planning/issues/56 for updates.

harrism avatar Jul 22 '24 23:07 harrism