rmm icon indicating copy to clipboard operation
rmm copied to clipboard

[skip gpuci] Add GitHub Actions workflow for PRs

Open jjacobelli opened this issue 3 years ago • 2 comments

TODO

jjacobelli avatar Jun 21 '22 08:06 jjacobelli

Should we push this to 22.10? Still a draft as we are entering code freeze.

harrism avatar Jul 28 '22 02:07 harrism

Should we push this to 22.10? Still a draft as we are entering code freeze.

Yes. I've updated the base branch.

raydouglass avatar Jul 28 '22 14:07 raydouglass

I think this PR would be a good opportunity to establish some conventions for the GitHub Check names shown in the screenshot below.

image

I'm partial to the following conventions:

* All lowercase characters

* Removing all spaces

* Using kebab case (e.g. something-like-this)

* Removing special characters (e.g. `cpp` instead of `c++`)

Let me know your thoughts.

It seems you would to have slugs as display name for the jobs. I'm not sure to understand why? I totally agree that we need to rethink about the names, but I think we should keep a good display name instead of slugs. WDYT?

jjacobelli avatar Sep 07 '22 12:09 jjacobelli

It seems you would to have slugs as display name for the jobs. I'm not sure to understand why? I totally agree that we need to rethink about the names, but I think we should keep a good display name instead of slugs. WDYT?

My main concern is the amount of text that is included in the GitHub Check itself. I think these should be succinct. Currently, they're very long. e.g.

image

compared to our Jenkins checks:

image

I think they both still convey an adequate amount of information to developers. But the first one is verbose and gets cut off in the GUI as a result.

So something like

pr / workflow / conda / python-build (11.5.1, ubuntu20.04, amd64, 3.8)

or

pr / workflow / conda-python / build (11.5.1, ubuntu20.04, amd64, 3.8)

instead of

CI for PRs / Workflow / Python build / Conda Python matrix build (11.5.1, ubuntu20.04, amd64, 3.8)

would be ideal I think.

ajschmidt8 avatar Sep 07 '22 13:09 ajschmidt8

Closed in favor of https://github.com/rapidsai/rmm/pull/1099

jjacobelli avatar Sep 23 '22 14:09 jjacobelli