dask-cudf icon indicating copy to clipboard operation
dask-cudf copied to clipboard

Published 20 hours ago • verified publisher icon rapidsai

[WIP] Remove stale join code, update tests

Open kkraus14 opened this issue 5 years ago • 4 comments

kkraus14 avatar May 28 '19 23:05 kkraus14

@mrocklin ping

kkraus14 avatar Jun 04 '19 21:06 kkraus14

i thought we were going to put this PR on the back burner while we sort out sorted joins in cuDF ?

quasiben avatar Jun 04 '19 21:06 quasiben

i thought we were going to put this PR on the back burner while we sort out sorted joins in cuDF ?

He asked for me to ping him just so he could take a look. I'm happy to put this on the back burner.

kkraus14 avatar Jun 04 '19 21:06 kkraus14

I took a brief look at this. My attempt was to add a tiny join method that would route things to the merge method. It turns out that i don't fully understand the expectations of the join API though and how it relates to things like index merging and so on. After a bit of time I gave up.

mrocklin avatar Jun 06 '19 21:06 mrocklin