dask-cuda icon indicating copy to clipboard operation
dask-cuda copied to clipboard

Avoid spilling if `device_memory_limit=0`

Open pentschev opened this issue 4 years ago • 7 comments

Distributed defines memory_limit=0 as unlimited, which prevents spilling to disk, such behavior was erratic in dask-cuda but is fixed by #269 .

The purpose of this issue is to raise information from people on whether a similar behavior would be useful/desirable for device_memory_limit, thus preventing spilling to host and consequently to disk as well. Thoughts @beckernick @mt-jones @jakirkham ?

pentschev avatar Mar 30 '20 19:03 pentschev

It's important to add that this is the behavior today, unless the user specify a limit. In other words, we would need to change the default behavior to match that of memory_limit.

pentschev avatar Mar 30 '20 19:03 pentschev

This should be fixed now, closing.

pentschev avatar May 05 '20 21:05 pentschev

This was implemented for device_memory_limit? I know memory_limit was done, but didn't see the other one. Was there a PR I missed?

jakirkham avatar May 05 '20 21:05 jakirkham

Oops, my mistake. Thanks for catching this @jakirkham .

pentschev avatar May 05 '20 21:05 pentschev

All good 🙂

jakirkham avatar May 05 '20 22:05 jakirkham

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

github-actions[bot] avatar Feb 16 '21 19:02 github-actions[bot]

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

github-actions[bot] avatar May 17 '21 19:05 github-actions[bot]