cuvs icon indicating copy to clipboard operation
cuvs copied to clipboard

[BUG] cuVS should copy its clang-format from other RAPIDS libs

Open harrism opened this issue 5 months ago • 0 comments

Describe the bug cuVS .clang-format does not include the header ordering code that was added for all other RAPIDS C++ libraries. E.g. from RAFT:

IncludeCategories:
  - Regex:           '^"' # quoted includes
    Priority:        1
  - Regex:           '^<(common|benchmarks|tests)/' # benchmark/test includes
    Priority:        2
  #- Regex:           '^<(cuspatial_test|cuproj_test)/' # cuSpatial/cuProj test includes
  #  Priority:        3
  - Regex:           '^<raft/' # RAFT includes
    Priority:        3
  - Regex:           '^<(cudf|cuml|raft|kvikio)' # Other RAPIDS includes
    Priority:        4
  - Regex:           '^<rmm/' # RMM includes
    Priority:        5
  - Regex:           '^<(thrust|cub|cuda)/' # CCCL includes
    Priority:        6
  - Regex:           '^<(cooperative_groups|cuco|cuda|device_types|driver_types|math_constants|nvtx3)' # CUDA includes
    Priority:        6
  - Regex:           '^<.*\..*' # other system includes (e.g. with a '.')
    Priority:        7
  - Regex:           '^<[^.]+' # STL includes (no '.')
    Priority:        8

As a result, header ordering is not consistent and not automatically formatted.

Expected behavior Start from the clang-format of existing RMM libraries.

harrism avatar Aug 29 '24 05:08 harrism