rapidsai
[WIP] Expose `extend()` in C API
This pull request requires additional validation before any workflows can run on NVIDIA's runners.
Pull request vetters can view their responsibilities here.
Contributors can view more details about this message here.
![copy-pr-bot[bot] avatar](https://avatars.githubusercontent.com/in/354886?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ajit283 I think we discussed generating a bigger dataset for the test case here. You could even use raft::random::make_blobs to accomplish this.
Done! We should look into the tests for this one.
- The previous approach was to test against a set of precomputed queries, expected neighbors and distances.
- This does not work anymore as we generate the dataset dynamically using
make_blobs(). Right now I am adding a static set of vectors to the dataset usingextend(), then query these vectors and check if I get them back with distance 0. This shows thatextend()works, but is generally a regression compared to the previous tests. - My ideas for improving the tests would be either to remove
make_blobs()and use a larger static dataset, or to calculate expected neighbors and distances at runtime using brute-force.
What do you think?
@cjnolet I added a test using the pairwise distance matrix as discussed in the call
Overall, I think this PR is taking shape and looking great! I think the remaining items are minimal- mostly just doing the diligence of capturing Github issues.
any idea why the style-check failed?
include-check FAILED! See below for errors...
File: cpp/test/neighbors/ann_cagra_c.cu
Line:18 use #include <...>
I can't see any issue with the include statement
@ajit283 looks like we have a couple style check failures. Those will need to be fixed to run ci to completion
